Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2025-01-21 Thread via GitHub
rluvaton closed pull request #1206: extract expressions to folders based on spark grouping URL: https://github.com/apache/datafusion-comet/pull/1206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2025-01-21 Thread via GitHub
andygrove commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2605894349 @rluvaton ok to close this PR now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2025-01-05 Thread via GitHub
rluvaton commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2571571096 > @rluvaton I think that this looks great but it is challenging to really review the PR with so many changes. > > What do you think about breaking this down into some smal

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2025-01-05 Thread via GitHub
rluvaton commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2571551720 No problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2025-01-03 Thread via GitHub
andygrove commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2569642133 @rluvaton I think that this looks great but it is challenging to really review the PR with so many changes. ![2025-01-03_11-20](https://github.com/user-attachments/asse

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2024-12-31 Thread via GitHub
andygrove commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2566645812 > Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location Awesome. I plan on reviewing this later this week. -- This is an automated

Re: [PR] extract expressions to folders based on spark grouping [datafusion-comet]

2024-12-30 Thread via GitHub
rluvaton commented on PR #1206: URL: https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2565417237 Thanks @andygrove, The PR is now ready, I moved all the functions to the correct location -- This is an automated message from the Apache Git Service. To respond to the messa