parthchandra commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951870079
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -872,6 +872,13 @@ fn cast_array(
let array = array_with_timezone(array, cast_options.timezon
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951776389
##
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##
@@ -70,13 +70,8 @@ object CometCast {
case _ =>
Unsup
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -872,6 +872,13 @@ fn cast_array(
let array = array_with_timezone(array, cast_options.timezone.
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -872,6 +872,13 @@ fn cast_array(
let array = array_with_timezone(array, cast_options.timezone.
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -872,6 +872,13 @@ fn cast_array(
let array = array_with_timezone(array, cast_options.timezone.
codecov-commenter commented on PR #1385:
URL:
https://github.com/apache/datafusion-comet/pull/1385#issuecomment-2651538005
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1385?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
parthchandra commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1950914558
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -872,6 +872,13 @@ fn cast_array(
let array = array_with_timezone(array, cast_options.timezon
himadripal opened a new pull request, #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385
Completes #375
- enable decimal to decimal
- remove hard coded castoptions to pass to native execution
- use a regex to match arrow invalid argument error.
## Which is