Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
parthchandra commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951870079 ## native/spark-expr/src/conversion_funcs/cast.rs: ## @@ -872,6 +872,13 @@ fn cast_array( let array = array_with_timezone(array, cast_options.timezon

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
kazuyukitanimura commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951776389 ## spark/src/main/scala/org/apache/comet/expressions/CometCast.scala: ## @@ -70,13 +70,8 @@ object CometCast { case _ => Unsup

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
himadripal commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041 ## native/spark-expr/src/conversion_funcs/cast.rs: ## @@ -872,6 +872,13 @@ fn cast_array( let array = array_with_timezone(array, cast_options.timezone.

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
himadripal commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041 ## native/spark-expr/src/conversion_funcs/cast.rs: ## @@ -872,6 +872,13 @@ fn cast_array( let array = array_with_timezone(array, cast_options.timezone.

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
himadripal commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1951694041 ## native/spark-expr/src/conversion_funcs/cast.rs: ## @@ -872,6 +872,13 @@ fn cast_array( let array = array_with_timezone(array, cast_options.timezone.

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
codecov-commenter commented on PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#issuecomment-2651538005 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1385?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] enable full decimal to decimal support [datafusion-comet]

2025-02-11 Thread via GitHub
parthchandra commented on code in PR #1385: URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1950914558 ## native/spark-expr/src/conversion_funcs/cast.rs: ## @@ -872,6 +872,13 @@ fn cast_array( let array = array_with_timezone(array, cast_options.timezon

[PR] enable full decimal to decimal support [datafusion-comet]

2025-02-10 Thread via GitHub
himadripal opened a new pull request, #1385: URL: https://github.com/apache/datafusion-comet/pull/1385 Completes #375 - enable decimal to decimal - remove hard coded castoptions to pass to native execution - use a regex to match arrow invalid argument error. ## Which is