Re: [PR] deprecate schema expressions [datafusion]

2025-05-07 Thread via GitHub
alamb commented on PR #15847: URL: https://github.com/apache/datafusion/pull/15847#issuecomment-2860258573 Marking as draft as I think this PR is no longer waiting on feedback and I am trying to clear review queue. Please mark it as ready for review when it is ready for another look --

Re: [PR] deprecate schema expressions [datafusion]

2025-04-26 Thread via GitHub
ajita-asthana commented on code in PR #15847: URL: https://github.com/apache/datafusion/pull/15847#discussion_r2061842522 ## datafusion/common/src/dfschema.rs: ## @@ -969,12 +969,15 @@ impl Display for DFSchema { /// widely used in the DataFusion codebase. pub trait ExprSchema

Re: [PR] deprecate schema expressions [datafusion]

2025-04-26 Thread via GitHub
ajita-asthana commented on code in PR #15847: URL: https://github.com/apache/datafusion/pull/15847#discussion_r2061842522 ## datafusion/common/src/dfschema.rs: ## @@ -969,12 +969,15 @@ impl Display for DFSchema { /// widely used in the DataFusion codebase. pub trait ExprSchema

Re: [PR] deprecate schema expressions [datafusion]

2025-04-26 Thread via GitHub
comphead commented on code in PR #15847: URL: https://github.com/apache/datafusion/pull/15847#discussion_r2061501099 ## datafusion/common/src/dfschema.rs: ## @@ -969,12 +969,15 @@ impl Display for DFSchema { /// widely used in the DataFusion codebase. pub trait ExprSchema: std

Re: [PR] deprecate schema expressions [datafusion]

2025-04-26 Thread via GitHub
comphead commented on code in PR #15847: URL: https://github.com/apache/datafusion/pull/15847#discussion_r2061500961 ## datafusion/common/src/dfschema.rs: ## @@ -969,12 +969,15 @@ impl Display for DFSchema { /// widely used in the DataFusion codebase. pub trait ExprSchema: std

[PR] deprecate schema expressions [datafusion]

2025-04-24 Thread via GitHub
ajita-asthana opened a new pull request, #15847: URL: https://github.com/apache/datafusion/pull/15847 ## Which issue does this PR close? - Closes #. ## Rationale for this change ## What changes are included in this PR? ## Are these changes t