Re: [PR] ci improvements [datafusion]

2024-12-24 Thread via GitHub
alamb commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896785019 ## .github/workflows/rust.yml: ## @@ -288,17 +318,20 @@ jobs: mv *.tbl ../datafusion/sqllogictest/test_files/tpch/data - name: Verify that benchmar

Re: [PR] ci improvements [datafusion]

2024-12-24 Thread via GitHub
alamb commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896735651 ## .github/actions/setup-builder/action.yaml: ## @@ -42,6 +42,8 @@ runs: "${RETRY[@]}" rustup component add rustfmt - name: Configure rust runtime env

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
Omega359 commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896196677 ## .github/workflows/rust.yml: ## @@ -288,17 +318,20 @@ jobs: mv *.tbl ../datafusion/sqllogictest/test_files/tpch/data - name: Verify that bench

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
Omega359 commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896192661 ## .github/actions/setup-builder/action.yaml: ## @@ -42,6 +42,8 @@ runs: "${RETRY[@]}" rustup component add rustfmt - name: Configure rust runtime e

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
Omega359 commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896187659 ## .github/actions/setup-builder/action.yaml: ## @@ -42,6 +42,8 @@ runs: "${RETRY[@]}" rustup component add rustfmt - name: Configure rust runtime e

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
Omega359 commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896184558 ## .github/actions/setup-rust-runtime/action.yaml: ## @@ -34,5 +34,6 @@ runs: echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV echo "SCCACHE_GHA_EN

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
alamb commented on code in PR #13876: URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896174869 ## .github/actions/setup-rust-runtime/action.yaml: ## @@ -34,5 +34,6 @@ runs: echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV echo "SCCACHE_GHA_ENABL

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
Omega359 commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2559855782 Thanks for the update - no rush on my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] ci improvements [datafusion]

2024-12-23 Thread via GitHub
alamb commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2559850885 I can not wait to test / review this but I think I will run out of time today -- hopefully either later today or tomorrow -- This is an automated message from the Apache Git Service.

Re: [PR] ci improvements [datafusion]

2024-12-21 Thread via GitHub
Omega359 commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2558283740 an uncached build: https://github.com/apache/datafusion/actions/runs/12449465274 a cached build: https://github.com/apache/datafusion/actions/runs/12449630002 -- This is an aut

Re: [PR] ci improvements [datafusion]

2024-12-21 Thread via GitHub
Omega359 commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2558282900 I've reverted the nextest changes for now as the github action to install the binary of it is not approved and building nextest from source would take longer than the time it saves

Re: [PR] ci improvements [datafusion]

2024-12-21 Thread via GitHub
Omega359 commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2558259239 > Thanks @Omega359 is it a draft? I dont see tests in checks No, but it should be. I can't seem to make it draft but apparently taiki-e/install-action@nextest is not an allowe

Re: [PR] ci improvements [datafusion]

2024-12-21 Thread via GitHub
comphead commented on PR #13876: URL: https://github.com/apache/datafusion/pull/13876#issuecomment-2558251132 is it a draft? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] ci improvements [datafusion]

2024-12-21 Thread via GitHub
Omega359 opened a new pull request, #13876: URL: https://github.com/apache/datafusion/pull/13876 ## Which issue does this PR close? Closes #13846, part of #13845 ## Rationale for this change Improve ci run time ## What changes are included in this PR?