Re: [PR] chore: reinstate find_df_window_func [datafusion]

2025-01-27 Thread via GitHub
andygrove closed pull request #13708: chore: reinstate find_df_window_func URL: https://github.com/apache/datafusion/pull/13708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] chore: reinstate find_df_window_func [datafusion]

2024-12-10 Thread via GitHub
andygrove commented on code in PR #13708: URL: https://github.com/apache/datafusion/pull/13708#discussion_r1878462026 ## datafusion/expr/src/expr.rs: ## @@ -840,6 +840,12 @@ impl WindowFunction { } } +/// Find DataFusion's built-in window function by name. +#[deprecated(

Re: [PR] chore: reinstate find_df_window_func [datafusion]

2024-12-10 Thread via GitHub
andygrove commented on code in PR #13708: URL: https://github.com/apache/datafusion/pull/13708#discussion_r1878459451 ## datafusion/expr/src/expr.rs: ## @@ -840,6 +840,12 @@ impl WindowFunction { } } +/// Find DataFusion's built-in window function by name. +#[deprecated(

Re: [PR] chore: reinstate find_df_window_func [datafusion]

2024-12-10 Thread via GitHub
findepi commented on code in PR #13708: URL: https://github.com/apache/datafusion/pull/13708#discussion_r1877895988 ## datafusion/expr/src/expr.rs: ## @@ -840,6 +840,12 @@ impl WindowFunction { } } +/// Find DataFusion's built-in window function by name. +#[deprecated(si

Re: [PR] chore: reinstate find_df_window_func [datafusion]

2024-12-09 Thread via GitHub
alamb commented on code in PR #13708: URL: https://github.com/apache/datafusion/pull/13708#discussion_r1876523695 ## datafusion/expr/src/expr.rs: ## @@ -840,6 +840,12 @@ impl WindowFunction { } } +/// Find DataFusion's built-in window function by name. +#[deprecated(sinc

[PR] chore: reinstate find_df_window_func [datafusion]

2024-12-09 Thread via GitHub
andygrove opened a new pull request, #13708: URL: https://github.com/apache/datafusion/pull/13708 ## Which issue does this PR close? N/A ## Rationale for this change Public API function `find_df_window_func` was removed in https://github.com/apache/datafu