Re: [PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-03 Thread via GitHub
andygrove merged PR #1600: URL: https://github.com/apache/datafusion-comet/pull/1600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-03 Thread via GitHub
andygrove commented on code in PR #1600: URL: https://github.com/apache/datafusion-comet/pull/1600#discussion_r2027194598 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -20,7 +20,10 @@ #[macro_export] macro_rules! hash_array { ($array_type: ident, $column: ident, $ha

Re: [PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-02 Thread via GitHub
andygrove commented on code in PR #1600: URL: https://github.com/apache/datafusion-comet/pull/1600#discussion_r2025298795 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -20,7 +20,10 @@ #[macro_export] macro_rules! hash_array { ($array_type: ident, $column: ident, $ha

Re: [PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-02 Thread via GitHub
codecov-commenter commented on PR #1600: URL: https://github.com/apache/datafusion-comet/pull/1600#issuecomment-2773201133 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1600?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-02 Thread via GitHub
parthchandra commented on code in PR #1600: URL: https://github.com/apache/datafusion-comet/pull/1600#discussion_r2025216115 ## native/spark-expr/src/hash_funcs/utils.rs: ## @@ -20,7 +20,10 @@ #[macro_export] macro_rules! hash_array { ($array_type: ident, $column: ident,

[PR] chore: Remove some unwraps in hashing code [datafusion-comet]

2025-04-02 Thread via GitHub
andygrove opened a new pull request, #1600: URL: https://github.com/apache/datafusion-comet/pull/1600 ## Which issue does this PR close? Closes https://github.com/apache/datafusion-comet/issues/1599 ## Rationale for this change ## What changes are included