Re: [PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-29 Thread via GitHub
andygrove merged PR #1670: URL: https://github.com/apache/datafusion-comet/pull/1670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-27 Thread via GitHub
EmilyMatt commented on code in PR #1670: URL: https://github.com/apache/datafusion-comet/pull/1670#discussion_r2062485241 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -430,55 +430,43 @@ class CometSparkSessionExtensions op,

Re: [PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-27 Thread via GitHub
EmilyMatt commented on code in PR #1670: URL: https://github.com/apache/datafusion-comet/pull/1670#discussion_r2062480644 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -430,55 +430,43 @@ class CometSparkSessionExtensions op,

Re: [PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-25 Thread via GitHub
kazuyukitanimura commented on code in PR #1670: URL: https://github.com/apache/datafusion-comet/pull/1670#discussion_r2061094604 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -430,55 +430,43 @@ class CometSparkSessionExtensions op

Re: [PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #1670: URL: https://github.com/apache/datafusion-comet/pull/1670#issuecomment-2822742197 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1670?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[PR] chore: Make Aggregate transformation more compact [datafusion-comet]

2025-04-22 Thread via GitHub
EmilyMatt opened a new pull request, #1670: URL: https://github.com/apache/datafusion-comet/pull/1670 ## Which issue does this PR close? Does not close anything, but is probably a step towards #1669. ## Rationale for this change There is needless nesting a