alamb merged PR #16071:
URL: https://github.com/apache/datafusion/pull/16071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#issuecomment-2902187253
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
logan-keede commented on PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#issuecomment-2899131520
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
logan-keede commented on PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#issuecomment-2898549810
There was some trouble with the approach mentioned by @gabotechs.
1. `FixedSizeList` does not support empty list.
2. You cant cast Columns if they have varying size.
logan-keede commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094534675
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
I guess so. I am currently travelling, I will try to do that tomorrow.
--
gabotechs commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094432291
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
👍 that's fair, I wonder if there's a way of having all these tests be
execute
logan-keede commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094229214
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
> Very nice that this was shipped so fast, thanks!
I did not do anyth
logan-keede commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094229214
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
> Very nice that this was shipped so fast, thanks!
I did not do anyth
logan-keede commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094229214
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
> Very nice that this was shipped so fast, thanks!
I did not do anyth
gabotechs commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094196073
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
Really nice to get this tested! maybe it's a bit overkill to add dedicated
.s
gabotechs commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094196073
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
Really nice to get this tested! maybe it's a bit overkill to add dedicated
.s
gabotechs commented on code in PR #16071:
URL: https://github.com/apache/datafusion/pull/16071#discussion_r2094196073
##
datafusion/sqllogictest/test_files/fixed_size_list.slt:
##
Review Comment:
Really nice to get this tested! maybe it's a bit overkill to add dedicated
.s
logan-keede opened a new pull request, #16071:
URL: https://github.com/apache/datafusion/pull/16071
## Which issue does this PR close?
- Closes #16032 .
## Rationale for this change
Using #16025 as reference, adding support and relevant tests for `LargeList`
and `Fix
13 matches
Mail list logo
