Re: [PR] add unit tests for expression functions [datafusion-python]

2025-05-17 Thread via GitHub
timsaucer merged PR #1121: URL: https://github.com/apache/datafusion-python/pull/1121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] add unit tests for expression functions [datafusion-python]

2025-05-16 Thread via GitHub
timsaucer commented on PR #1121: URL: https://github.com/apache/datafusion-python/pull/1121#issuecomment-2887291492 Thank you all! Great suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] add unit tests for expression functions [datafusion-python]

2025-05-16 Thread via GitHub
kevinjqliu commented on code in PR #1121: URL: https://github.com/apache/datafusion-python/pull/1121#discussion_r2093257339 ## python/tests/test_expr.py: ## @@ -275,3 +277,465 @@ def test_col_getattr(): def test_alias_with_metadata(df): df = df.select(col("a").alias("b",

Re: [PR] add unit tests for expression functions [datafusion-python]

2025-04-29 Thread via GitHub
timsaucer commented on PR #1121: URL: https://github.com/apache/datafusion-python/pull/1121#issuecomment-2838964166 FYI @deanm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] add unit tests for expression functions [datafusion-python]

2025-04-29 Thread via GitHub
timsaucer opened a new pull request, #1121: URL: https://github.com/apache/datafusion-python/pull/1121 # Which issue does this PR close? Follow on to https://github.com/apache/datafusion-python/issues/1116 # Rationale for this change We don't have code coverage for these