Re: [PR] add method SessionStateBuilder::new_with_defaults() [datafusion]

2025-03-04 Thread via GitHub
shruti2522 commented on code in PR #14998: URL: https://github.com/apache/datafusion/pull/14998#discussion_r1979327789 ## datafusion/core/src/execution/session_state.rs: ## @@ -1109,6 +1109,22 @@ impl SessionStateBuilder { .with_table_function_list(SessionStateDefa

Re: [PR] add method SessionStateBuilder::new_with_defaults() [datafusion]

2025-03-04 Thread via GitHub
alamb commented on code in PR #14998: URL: https://github.com/apache/datafusion/pull/14998#discussion_r1979267227 ## datafusion/core/src/execution/session_state.rs: ## @@ -1109,6 +1109,22 @@ impl SessionStateBuilder { .with_table_function_list(SessionStateDefaults:

Re: [PR] add method SessionStateBuilder::new_with_defaults() [datafusion]

2025-03-04 Thread via GitHub
alamb commented on PR #14998: URL: https://github.com/apache/datafusion/pull/14998#issuecomment-2697248930 > Why don't we just implement Default trait? There is some more backstory here: - https://github.com/apache/datafusion/pull/14935#pullrequestreview-2654150748 Basically

Re: [PR] add method SessionStateBuilder::new_with_defaults() [datafusion]

2025-03-03 Thread via GitHub
berkaysynnada commented on PR #14998: URL: https://github.com/apache/datafusion/pull/14998#issuecomment-2696506200 Why don't we just implement Default trait? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] add method SessionStateBuilder::new_with_defaults() [datafusion]

2025-03-03 Thread via GitHub
shruti2522 opened a new pull request, #14998: URL: https://github.com/apache/datafusion/pull/14998 ## Which issue does this PR close? - Closes #14981 ## Rationale for this change ## What changes are included in this PR? added method `new_with_defaults`