Re: [PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-06 Thread via GitHub
alamb commented on PR #14009: URL: https://github.com/apache/datafusion/pull/14009#issuecomment-2572999127 (BTW welcome back @Jefffrey -- it is great to have you around!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-06 Thread via GitHub
Jefffrey commented on PR #14009: URL: https://github.com/apache/datafusion/pull/14009#issuecomment-2572965242 Thanks @alamb Raised #14022 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-06 Thread via GitHub
Jefffrey merged PR #14009: URL: https://github.com/apache/datafusion/pull/14009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-05 Thread via GitHub
alamb commented on PR #14009: URL: https://github.com/apache/datafusion/pull/14009#issuecomment-2571709524 I also found this gem: - https://github.com/foresterre/cargo-msrv/pull/882 (thanks @Jefffrey ❤️ ) -- This is an automated message from the Apache Git Service. To respond to the me

[PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-04 Thread via GitHub
Jefffrey opened a new pull request, #14009: URL: https://github.com/apache/datafusion/pull/14009 ## Which issue does this PR close? Closes #9214 ## Rationale for this change `cargo-msrv` version `0.16.0` includes the upstream fix we needed (though current

Re: [PR] Use workspace rust-version for all workspace crates [datafusion]

2025-01-04 Thread via GitHub
Jefffrey commented on code in PR #14009: URL: https://github.com/apache/datafusion/pull/14009#discussion_r1903177589 ## datafusion-cli/Cargo.toml: ## @@ -25,7 +25,6 @@ keywords = ["arrow", "datafusion", "query", "sql"] license = "Apache-2.0" homepage = "https://datafusion.apac