Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2654980522 Thanks again @lgingerich -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb merged PR #14525: URL: https://github.com/apache/datafusion/pull/14525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2650627501 I took the liberty of merging this PR up from main to resolve some conflicts: ![Screenshot 2025-02-11 at 7 10 48  AM](https://github.com/user-attachments/assets/e2d4b812-58f8-458a

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2648504081 > I'll check out these new errors later today. > > Is there a simple way to run all these tests locally without manually running each of the difference cargo test combinations? (

Re: [PR] Use ` take_function_args` in more places [datafusion]

lgingerich commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2648489071 I'll check out these new errors later today. Is there a simple way to run all these tests locally without manually running each of the difference cargo test combinations? (I

Re: [PR] Use ` take_function_args` in more places [datafusion]

lgingerich commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2648325869 @alamb Should be fixed now. I just didn't have the language of the test properly matching this new function. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2648250092 Thank you so much @lgingerich I started the CI checks FYI When I ran some of the tests locally I saw some failures which seem to be related: ``` cargo test

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on PR #14525: URL: https://github.com/apache/datafusion/pull/14525#issuecomment-2648247269 FYI @findepi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Use ` take_function_args` in more places [datafusion]

alamb commented on code in PR #14525: URL: https://github.com/apache/datafusion/pull/14525#discussion_r1949200715 ## datafusion/expr/src/test/function_stub.rs: ## @@ -125,9 +125,7 @@ impl AggregateUDFImpl for Sum { } fn coerce_types(&self, arg_types: &[DataType]) ->