alamb commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2873452897
Thanks again@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb merged PR #15612:
URL: https://github.com/apache/datafusion/pull/15612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Max-Meldrum commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2869668640
I believe this PR is now ready to be merged @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Max-Meldrum commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2815924192
@the0ninjas
It should passes the test if **```rust,ignore** is used instead. And we
could link a reference to the external code
https://github.com/uwheel/datafusion-uwhe
alamb commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2813589469
Another alternate to make the doc tests pass is to comment the code out,
using
```
# /*
...
*/
```
For example, see
- https://github.com/apache/datafusion/pull/
alamb commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2812928015
> For instance the
[try_rewrite](https://github.com/uwheel/datafusion-uwheel/blob/2c88c5ea7629515ad551f968108e87de4133fe5f/datafusion-uwheel/src/lib.rs#L246)
function. What could be a
Max-Meldrum commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2812023934
> > Seems like it is actually trying to compile the doctest code. If this
isn't required then perhaps a `no_run` is in order?
>
> Yes, we run all the examples in the doc te
Max-Meldrum commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2785973373
Seems like it is actually trying to compile the doctest code. If this isn't
required then perhaps a `no_run` is in order?
--
This is an automated message from the Apache Git Se
alamb commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2787104370
> Seems like it is actually trying to compile the doctest code. If this
isn't required then perhaps a `no_run` is in order?
Yes, we run all the examples in the doc tests -- instr
alamb commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2787106769
Thank you for this contribution @the0ninjas and the hints @Max-Meldrum
I am marking the PR as draft while we work on getting the CI passing. Then
please mark it ready for revie
the0ninjas opened a new pull request, #15612:
URL: https://github.com/apache/datafusion/pull/15612
## Which issue does this PR close?
- Closes #15422
## What changes are included in this PR?
- Updated the [documentation
page](https://datafusion.apache.org/library-user-guide/ext
the0ninjas commented on PR #15612:
URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2782419740
@alamb - Since I'm first-time contributor, could you help trigger the CI
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
12 matches
Mail list logo
