Re: [PR] Update logical-types to main [datafusion]

2025-01-21 Thread via GitHub
tobixdev commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2606480100 > I am now working on a different branch of mine to ensure that the merge commit is properly handled. Here is the diff between said branch and main which only contains the changes w

Re: [PR] Update logical-types to main [datafusion]

2025-01-21 Thread via GitHub
jayzhan211 commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2606044074 > Thanks! Should I open a new PR so that we can try it with the new branch? What do you mean new branch -- This is an automated message from the Apache Git Service. To res

Re: [PR] Update logical-types to main [datafusion]

2025-01-21 Thread via GitHub
tobixdev commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2604503486 Thanks! Should I open a new PR so that we can try it with the new branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Update logical-types to main [datafusion]

2025-01-21 Thread via GitHub
jayzhan211 commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2604478227 I force push to the previous commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update logical-types to main [datafusion]

2025-01-21 Thread via GitHub
jayzhan211 commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2604471874 We can revert revert it, but I think what you did is correct, not sure what happen 🤔 ? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Update logical-types to main [datafusion]

2025-01-20 Thread via GitHub
tobixdev commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2602281685 So something has gone wrong here. For example, the `.devcontainer/Dockerfile` is equivalent to the one on main but I think that the information that this was a merge commit got lost

Re: [PR] Update logical-types to main [datafusion]

2025-01-19 Thread via GitHub
tobixdev commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2601483855 I'll have a look at it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Update logical-types to main [datafusion]

2025-01-19 Thread via GitHub
jayzhan211 commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2601124055 ![Screenshot 2025-01-20 at 9 00 09  AM](https://github.com/user-attachments/assets/9a4e2a33-3913-43b1-ab81-8d66e3d7cb2e) I compare it with the `main`, it includes unexpected chan

Re: [PR] Update logical-types to main [datafusion]

2025-01-19 Thread via GitHub
jayzhan211 commented on PR #14202: URL: https://github.com/apache/datafusion/pull/14202#issuecomment-2601119156 I will just merge this, since it is a rebase to `logical-types` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Update logical-types to main [datafusion]

2025-01-19 Thread via GitHub
jayzhan211 merged PR #14202: URL: https://github.com/apache/datafusion/pull/14202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat