Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-22 Thread via GitHub
alamb commented on PR #16465: URL: https://github.com/apache/datafusion/pull/16465#issuecomment-2994205944 We think we have fixed the real cause in - https://github.com/apache/datafusion/pull/16491 Here is a PR to restore the related code in - https://github.com/apache/datafusio

Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-20 Thread via GitHub
alamb commented on PR #16465: URL: https://github.com/apache/datafusion/pull/16465#issuecomment-2991746831 Thanks @adriangb and @blaginin for sorting this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-19 Thread via GitHub
adriangb commented on PR #16465: URL: https://github.com/apache/datafusion/pull/16465#issuecomment-2989282614 Sad to have to do this but I agree keeping CI green is the top priority cc @Dandandan -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-19 Thread via GitHub
adriangb merged PR #16465: URL: https://github.com/apache/datafusion/pull/16465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-19 Thread via GitHub
AdamGS commented on code in PR #16465: URL: https://github.com/apache/datafusion/pull/16465#discussion_r2157698764 ## datafusion/core/tests/fuzz_cases/sort_query_fuzz.rs: ## @@ -579,6 +618,7 @@ impl SortFuzzerTestGenerator { let with_mem_limit = !query_str.contains("LIM

Re: [PR] Temporarily fix bug in dynamic top-k optimization [datafusion]

2025-06-19 Thread via GitHub
adriangb commented on code in PR #16465: URL: https://github.com/apache/datafusion/pull/16465#discussion_r2157671900 ## datafusion/core/tests/fuzz_cases/sort_query_fuzz.rs: ## @@ -579,6 +618,7 @@ impl SortFuzzerTestGenerator { let with_mem_limit = !query_str.contains("L