Re: [PR] Support within group syntax for existing aggregate functions [datafusion]

2025-01-30 Thread via GitHub
Garamda commented on code in PR #13511: URL: https://github.com/apache/datafusion/pull/13511#discussion_r1929539094 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -77,36 +77,38 @@ SELECT approx_distinct(c9) count_c9, approx_distinct(cast(c9 as varchar)) count_ #

Re: [PR] Support within group syntax for existing aggregate functions [datafusion]

2025-01-25 Thread via GitHub
Garamda commented on code in PR #13511: URL: https://github.com/apache/datafusion/pull/13511#discussion_r1929539094 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -77,36 +77,38 @@ SELECT approx_distinct(c9) count_c9, approx_distinct(cast(c9 as varchar)) count_ #

Re: [PR] Support within group syntax for existing aggregate functions [datafusion]

2025-01-20 Thread via GitHub
Garamda commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2603484747 > Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will

Re: [PR] Support within group syntax for existing aggregate functions [datafusion]

2025-01-20 Thread via GitHub
github-actions[bot] commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2603471606 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Support within group syntax for existing aggregate functions [datafusion]

2024-11-21 Thread via GitHub
alamb commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2492389897 FYI @Dandandan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Support within group syntax for existing aggregate functions [datafusion]

2024-11-20 Thread via GitHub
Garamda opened a new pull request, #13511: URL: https://github.com/apache/datafusion/pull/13511 ## Which issue does this PR close? Closes #11732. (cc. #12824) ## Rationale for this change ## What changes are included in this PR? ## Are these