goldmedal commented on PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#issuecomment-2561877406
Thanks @alamb @phillipleblanc @sgrebnov 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#issuecomment-2561866371
Thanks again @goldmedal @phillipleblanc and @sgrebnov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb merged PR #13824:
URL: https://github.com/apache/datafusion/pull/13824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#issuecomment-2561182687
I plan to merge tomorrow unless someone beats me to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sgrebnov commented on PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#issuecomment-2558607823
Looks good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
goldmedal commented on code in PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#discussion_r1894582202
##
datafusion/sql/src/unparser/plan.rs:
##
@@ -723,19 +733,48 @@ impl Unparser<'_> {
internal_err!("Unnest input is not a Projection:
{unne
goldmedal commented on code in PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#discussion_r1894582093
##
datafusion/sql/src/unparser/rewrite.rs:
##
@@ -257,6 +267,43 @@ pub(super) fn subquery_alias_inner_query_and_columns(
(outer_projections.input.as_ref(),
goldmedal commented on code in PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#discussion_r1894580268
##
datafusion/sql/src/unparser/plan.rs:
##
@@ -723,19 +733,48 @@ impl Unparser<'_> {
internal_err!("Unnest input is not a Projection:
{unne
phillipleblanc commented on code in PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#discussion_r1893430912
##
datafusion/sql/src/unparser/rewrite.rs:
##
@@ -257,6 +267,43 @@ pub(super) fn subquery_alias_inner_query_and_columns(
(outer_projections.input.as_re
alamb commented on PR #13824:
URL: https://github.com/apache/datafusion/pull/13824#issuecomment-2554023379
@phillipleblanc or @sgrebnov I wonder if you have interest/time to help
review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
goldmedal opened a new pull request, #13824:
URL: https://github.com/apache/datafusion/pull/13824
## Which issue does this PR close?
Closes #13793
## Rationale for this change
## What changes are included in this PR?
## Are these changes tes
11 matches
Mail list logo
