iffyio merged PR #1759:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
simonvandel commented on PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#issuecomment-2843224034
> @simonvandel could you take a look at the CI issues when you get the time?
I think CI should be green with
https://github.com/apache/datafusion-sqlparser-rs/p
iffyio commented on PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#issuecomment-2837681286
@simonvandel could you take a look at the CI issues when you get the time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
simonvandel commented on PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#issuecomment-2836116631
Thanks @iffyio
I resolved the merge conflict, fixed your comment on error handling.
Additionally, I added a dialect check before parsing pipe operators. See
simonvandel commented on code in PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#discussion_r2064251738
##
src/parser/mod.rs:
##
@@ -10574,11 +10598,96 @@ impl<'a> Parser<'a> {
for_clause,
settings,
f
iffyio commented on code in PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#discussion_r2062500408
##
src/parser/mod.rs:
##
@@ -10574,11 +10598,96 @@ impl<'a> Parser<'a> {
for_clause,
settings,
format
simonvandel commented on PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#issuecomment-2810341974
Hi @iffyio
I'm sorry for the long response time.
I have now revised the code according to your comments.
Adding more tests found some bugs, so I had to ch
iffyio commented on code in PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#discussion_r1992171898
##
src/ast/query.rs:
##
@@ -2407,6 +2413,98 @@ impl fmt::Display for OffsetRows {
}
}
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Ha
simonvandel opened a new pull request, #1759:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1759
Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1758
Still missing (ran out of time today, can be done in follow-ups perhaps)
- join
- union|intersect|e
