kylebarron commented on PR #975:
URL:
https://github.com/apache/datafusion-python/pull/975#issuecomment-2580599804
Thanks for making that update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
timsaucer merged PR #975:
URL: https://github.com/apache/datafusion-python/pull/975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
timsaucer commented on code in PR #975:
URL: https://github.com/apache/datafusion-python/pull/975#discussion_r1907919652
##
python/datafusion/record_batch.py:
##
@@ -59,18 +59,22 @@ def __init__(self, record_batch_stream:
df_internal.RecordBatchStream) -> None:
def next(
timsaucer commented on code in PR #975:
URL: https://github.com/apache/datafusion-python/pull/975#discussion_r1905447211
##
python/datafusion/record_batch.py:
##
@@ -59,18 +59,22 @@ def __init__(self, record_batch_stream:
df_internal.RecordBatchStream) -> None:
def next(
kylebarron commented on PR #975:
URL:
https://github.com/apache/datafusion-python/pull/975#issuecomment-2549262305
I'd like to add a test with pytest-asyncio, but I don't know how to add the
dependency, ref #977
--
This is an automated message from the Apache Git Service.
To respond to
kylebarron commented on PR #975:
URL:
https://github.com/apache/datafusion-python/pull/975#issuecomment-2549231264
This PR changes the behavior of `stream.next()` to raise `StopIteration`
when there are no more batches available in the stream.
This matches default iterator behavior:
timsaucer commented on PR #975:
URL:
https://github.com/apache/datafusion-python/pull/975#issuecomment-2548366767
At first glance, this looks like a very nice add. Do you need help resolving
the test failures?
--
This is an automated message from the Apache Git Service.
To respond to the
kylebarron commented on PR #975:
URL:
https://github.com/apache/datafusion-python/pull/975#issuecomment-2546768589
If this looks good, we can add a test using pytest-asyncio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kylebarron opened a new pull request, #975:
URL: https://github.com/apache/datafusion-python/pull/975
# Which issue does this PR close?
Closes #974 .
# Rationale for this change
Support async iteration of RecordBatchStream.
# What changes are included in this PR?
