Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-04-05 Thread via GitHub
alamb commented on PR #15310: URL: https://github.com/apache/datafusion/pull/15310#issuecomment-2739772947 Thanks again @svranesevic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-04-05 Thread via GitHub
svranesevic commented on PR #15310: URL: https://github.com/apache/datafusion/pull/15310#issuecomment-2740356069 > I normally try and wait for abour 24 hours before merging non trivial approved PRs to give a chance for other contributors in different timezones to review Oh, I was not

Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-03-20 Thread via GitHub
alamb commented on PR #15310: URL: https://github.com/apache/datafusion/pull/15310#issuecomment-2739772489 https://github.com/user-attachments/assets/c4de068f-d54e-4125-9392-ea77c6cfd308"; /> Will do -- thanks @svranesevic I normally try and wait for abour 24 hours before merging

Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-03-20 Thread via GitHub
alamb merged PR #15310: URL: https://github.com/apache/datafusion/pull/15310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-03-19 Thread via GitHub
svranesevic commented on PR #15310: URL: https://github.com/apache/datafusion/pull/15310#issuecomment-2739373267 Thanks @alamb! Feel free to merge whenever, it seems that I can not do so even after approval. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Support Duration in min/max agg functions [datafusion]

2025-03-19 Thread via GitHub
alamb commented on code in PR #15310: URL: https://github.com/apache/datafusion/pull/15310#discussion_r2004167614 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -3807,6 +3807,38 @@ SELECT MIN(value), MAX(value) FROM timestampmicrosecond statement ok DROP TABLE time

[PR] Support Duration in min/max agg functions [datafusion]

2025-03-19 Thread via GitHub
svranesevic opened a new pull request, #15310: URL: https://github.com/apache/datafusion/pull/15310 ## Which issue does this PR close? / ## Rationale for this change Support min/max aggregation of expressions with duration type. ## What changes are