simonvandel commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1957081225
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal
simonvandel commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1957080918
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal
Dandandan commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1957035222
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal_e
comphead commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660554270
@simonvandel I'd like to ask you to create a slt test for UUID(), I know it
is non guaranteed output, but we can check the v4 validity format I suppose.
--
This is an automated me
comphead commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1956877727
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal_er
simonvandel commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660484055
Oops, need to generate valid uuidv4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
simonvandel opened a new pull request, #14675:
URL: https://github.com/apache/datafusion/pull/14675
## Which issue does this PR close?
N/A
## Rationale for this change
It seems to be faster to generate random u128's in bulk, and then converting
them to Uuids.
