xudong963 merged PR #16362:
URL: https://github.com/apache/datafusion/pull/16362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
alamb commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2162482061
##
datafusion/optimizer/src/simplify_expressions/simplify_predicates.rs:
##
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2161147718
##
datafusion/optimizer/src/simplify_predicates.rs:
##
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2161387780
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -778,6 +779,16 @@ impl OptimizerRule for PushDownFilter {
return Ok(Transformed::no(plan));
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2161366914
##
datafusion/optimizer/src/simplify_predicates.rs:
##
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2161280602
##
datafusion/optimizer/src/simplify_predicates.rs:
##
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2161141184
##
datafusion/expr/src/expr.rs:
##
@@ -2069,6 +2069,11 @@ impl Expr {
_ => None,
}
}
+
+/// Check if the Expr is literal
Review C
xudong963 commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2160887410
##
datafusion/optimizer/src/simplify_predicates.rs:
##
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
alamb commented on code in PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#discussion_r2160308484
##
datafusion/optimizer/src/simplify_predicates.rs:
##
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
alamb commented on PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#issuecomment-2993540037
🤖: Benchmark completed
Details
```
group main
simplify_predicates
-
alamb commented on PR #16362:
URL: https://github.com/apache/datafusion/pull/16362#issuecomment-2993516948
🤖 `./gh_compare_branch_bench.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch_bench.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~
11 matches
Mail list logo
