Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-15 Thread via GitHub
alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1996154726 ## datafusion/sqllogictest/test_files/explain_tree.slt: ## @@ -739,43 +736,42 @@ physical_plan 01)┌───┐ 02)│ ProjectionExec │ 0

Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-14 Thread via GitHub
alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1996216639 ## datafusion/physical-expr-common/src/physical_expr.rs: ## @@ -379,3 +396,53 @@ where DisplayWrapper(exprs.into_iter()) } + +/// Prints a [`PhysicalExpr`] i

Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-14 Thread via GitHub
alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1996155083 ## datafusion/sqllogictest/test_files/explain_tree.slt: ## @@ -704,29 +704,26 @@ physical_plan 01)┌───┐ 02)│ ProjectionExec │ 0

Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-14 Thread via GitHub
irenjj commented on PR #15163: URL: https://github.com/apache/datafusion/pull/15163#issuecomment-2724520622 Thanks @alamb , have added an example for Projection, it looks better than before. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-13 Thread via GitHub
alamb commented on code in PR #15163: URL: https://github.com/apache/datafusion/pull/15163#discussion_r1993875533 ## datafusion/physical-expr-common/src/physical_expr.rs: ## @@ -266,6 +266,8 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug + DynEq + DynHash { fn ge

Re: [PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-12 Thread via GitHub
alamb commented on PR #15163: URL: https://github.com/apache/datafusion/pull/15163#issuecomment-2719256811 Thank you @irenjj - I will check this out later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Simpler to see expressions in tree explain mode [datafusion]

2025-03-11 Thread via GitHub
irenjj opened a new pull request, #15163: URL: https://github.com/apache/datafusion/pull/15163 ## Which issue does this PR close? - Closes #15107 ## Rationale for this change ## What changes are included in this PR? ## Are these changes test