github-actions[bot] closed pull request #14668: Simple Functions Preview
URL: https://github.com/apache/datafusion/pull/14668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-3030282290
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2841237225
hey stale bot, your're right. I owe status update. TL;DR: no update, as we
refocused away from execution in recent months. I still find this very
valuable for compute, but can't pr
github-actions[bot] commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2840626218
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
jayzhan211 commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2686798534
> Implementing a function that should be called also for null input requires
declaring it, by wrapping relevant arguments in Option<...>
If we can handle `Option` as `null`
jayzhan211 commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2676540174
I don't find it outperform the existing function 🫤
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jayzhan211 commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2673054919
> I don't have expectations that generic implementation will be faster than
50x[1](https://github.com/apache/datafusion/pull/14668#user-content-fn-1-8db9f2d544d304aebaed47866e77cf6
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2672254750
I bencharked
```rust
#[excalibur_function]
fn character_length(s: &str) -> i32 {
s.chars().count() as i32
}
```
comparing it with the `character_length` im
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2670665041
Marked this as non-draft. It would be great to have reviews here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2666294942
Added support for out types:
```rust
#[excalibur_function]
fn concat(a: &str, b: &str, out: &mut impl std::fmt::Write) ->
Result {
if a.is_empty() && b.is_empty()
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2665079336
i learned a bunch during last few days, being thrown at pages like below,
which are good read
- https://github.com/dtolnay/case-studies
- https://blog.rust-lang.org/2022/10/
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2661609322
> Is it possible to define a function using generics?
currently not.
> Otherwise, will we need to duplicate the function for different types?
currently yes; which
jayzhan211 commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2661187751
```rust
#[excalibur_function]
fn add(a: i32, b: u32) -> i64 {
a as i64 + b as i64
}
```
Is it possible to define a function using generics? Otherwise, will
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2660287208
i now also have support for
various numeric
```rust
#[excalibur_function]
fn add(a: i32, b: u32) -> i64 {
a as i64 + b as i64
}
```
nullable fu
findepi opened a new pull request, #14668:
URL: https://github.com/apache/datafusion/pull/14668
This is currently a preview PR for
https://github.com/apache/datafusion/issues/12635 to share status of the work.
Based on `add_one` function, this creates `add_one_udf` (by convention,
co
15 matches
Mail list logo
