alamb merged PR #16122:
URL: https://github.com/apache/datafusion/pull/16122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16122:
URL: https://github.com/apache/datafusion/pull/16122#issuecomment-2917166418
Thanks @timsaucer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on PR #16122:
URL: https://github.com/apache/datafusion/pull/16122#issuecomment-2905409675
> Can you expand on this a little? Was there a specific metric you were
watching to see performance improvements or is it looking at the code that we
roughly have the same number of al
timsaucer commented on PR #16122:
URL: https://github.com/apache/datafusion/pull/16122#issuecomment-2904018396
> I had hoped this would be a bigger improvement, but I think it at least
sets us up for being more efficient / less String cloning going forward
Can you expand on this a lit
alamb commented on code in PR #16122:
URL: https://github.com/apache/datafusion/pull/16122#discussion_r2103200355
##
datafusion/functions/src/datetime/now.rs:
##
@@ -77,12 +77,13 @@ impl ScalarUDFImpl for NowFunc {
&self.signature
}
-fn return_field_from_args
timsaucer opened a new pull request, #16122:
URL: https://github.com/apache/datafusion/pull/16122
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/16121
## Rationale for this change
With the switch from `DataType` to `Field` we may h
