alamb commented on PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#issuecomment-2838662506
Thanks again @ctsk -- sorry for the delay in review / merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
alamb merged PR #15783:
URL: https://github.com/apache/datafusion/pull/15783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#issuecomment-2837274656
> │ QQuery 4 │ 887.43ms │ 740.13ms │ +1.20x faster │
Given these queries don't have joins I am not sure that is reproduceable 😬
--
This is an automated message
alamb commented on PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#issuecomment-2837217773
🤖: Benchmark completed
Details
```
Comparing HEAD and fix_hash-join-seed
Benchmark clickbench_extended.json
alamb commented on code in PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#discussion_r2065171783
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -86,6 +86,10 @@ use datafusion_physical_expr_common::physical_expr::fmt_sql;
use futures::{ready, Stream,
alamb commented on PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#issuecomment-2837160708
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun
Weijun-H commented on code in PR #15783:
URL: https://github.com/apache/datafusion/pull/15783#discussion_r2052164212
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -86,6 +86,9 @@ use datafusion_physical_expr_common::physical_expr::fmt_sql;
use futures::{ready, Stream
ctsk opened a new pull request, #15783:
URL: https://github.com/apache/datafusion/pull/15783
## Which issue does this PR close?
- Closes #15620.
## What changes are included in this PR?
The hash join seed is hard-coded to a different value that the
RepartitionExec seed.
