Re: [PR] Scrollable python notebook table rendering [datafusion-python]

2025-03-13 Thread via GitHub
timsaucer commented on PR #1036: URL: https://github.com/apache/datafusion-python/pull/1036#issuecomment-2721032760 I am testing my updated consolidated code now. When running on a 10 GB scale factor TPC-H query, I get comparable times for both q1 and q2, which take 10 and 53 s on my m4 pr

Re: [PR] Scrollable python notebook table rendering [datafusion-python]

2025-03-12 Thread via GitHub
timsaucer commented on PR #1036: URL: https://github.com/apache/datafusion-python/pull/1036#issuecomment-2719319267 Still needs careful testing and performance evaluation, but trying to pull in methods for this issue, #1041 and #1015 into a single PR -- This is an automated message from

Re: [PR] Scrollable python notebook table rendering [datafusion-python]

2025-03-04 Thread via GitHub
kevinjqliu commented on code in PR #1036: URL: https://github.com/apache/datafusion-python/pull/1036#discussion_r1979772203 ## src/dataframe.rs: ## @@ -100,46 +106,153 @@ impl PyDataFrame { } fn _repr_html_(&self, py: Python) -> PyDataFusionResult { -let mut

Re: [PR] Scrollable python notebook table rendering [datafusion-python]

2025-03-01 Thread via GitHub
timsaucer commented on PR #1036: URL: https://github.com/apache/datafusion-python/pull/1036#issuecomment-2692325079 I need to update the unit test. I don't think the just validating it hasn't changed is exactly what we need, so I may think about it some more. -- This is an automated mess

[PR] Scrollable python notebook table rendering [datafusion-python]

2025-03-01 Thread via GitHub
timsaucer opened a new pull request, #1036: URL: https://github.com/apache/datafusion-python/pull/1036 # Which issue does this PR close? None. # Rationale for this change The notebook rendering of DataFrames is very useful, but it can be enhanced. This PR adds quality o