alamb merged PR #14412:
URL: https://github.com/apache/datafusion/pull/14412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2038100274
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -65,6 +83,7 @@ make_udaf_expr_and_func!(
#[derive(Debug)]
pub struct StringAgg {
signature: Signatu
geoffreyclaude commented on PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#issuecomment-2783476941
@alamb all good for me! You can give the final review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2026461993
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -129,52 +172,326 @@ impl AggregateUDFImpl for StringAgg {
#[derive(Debug)]
pub(crate) struct Strin
alamb commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2028567883
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -129,52 +172,326 @@ impl AggregateUDFImpl for StringAgg {
#[derive(Debug)]
pub(crate) struct StringAgg
gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2028725710
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -129,52 +172,326 @@ impl AggregateUDFImpl for StringAgg {
#[derive(Debug)]
pub(crate) struct Strin
alamb commented on PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#issuecomment-2778282626
@geoffreyclaude when you think this PR is ready, can you please ping me and
I'll give it a review?
--
This is an automated message from the Apache Git Service.
To respond to the me
gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2026461993
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -129,52 +172,326 @@ impl AggregateUDFImpl for StringAgg {
#[derive(Debug)]
pub(crate) struct Strin
gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2026415116
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -65,6 +83,7 @@ make_udaf_expr_and_func!(
#[derive(Debug)]
pub struct StringAgg {
signature: Sig
geoffreyclaude commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r1981567196
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100
NULL
+query T
+S
gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r1963954221
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100
NULL
+query T
+SELECT
geoffreyclaude commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r1962046382
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -106,20 +113,40 @@ impl AggregateUDFImpl for StringAgg {
Ok(DataType::LargeUtf8)
}
geoffreyclaude commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r1962048387
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100
NULL
+query T
+S
alamb closed pull request #14412: STRING_AGG missing functionality
URL: https://github.com/apache/datafusion/pull/14412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
alamb commented on PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#issuecomment-2634783601
Close/reopen to rerun CI checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alamb closed pull request #14412: STRING_AGG missing functionality
URL: https://github.com/apache/datafusion/pull/14412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
16 matches
Mail list logo
