adriangb merged PR #16791:
URL: https://github.com/apache/datafusion/pull/16791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211616561
##
datafusion/core/tests/parquet/schema_adapter.rs:
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211267704
##
docs/source/library-user-guide/upgrading.md:
##
@@ -120,6 +120,17 @@ SET datafusion.execution.spill_compression = 'zstd';
For more details about this configura
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211280296
##
datafusion/datasource-parquet/src/source.rs:
##
@@ -468,10 +468,50 @@ impl FileSource for ParquetSource {
let projection = base_config
.f
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211279282
##
datafusion/core/tests/parquet/schema_adapter.rs:
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211266501
##
datafusion/datasource-parquet/src/source.rs:
##
@@ -468,10 +468,50 @@ impl FileSource for ParquetSource {
let projection = base_config
.file
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2211108359
##
datafusion/datasource-parquet/src/opener.rs:
##
@@ -1095,4 +1124,167 @@ mod test {
assert_eq!(num_batches, 0);
assert_eq!(num_rows, 0);
adriangb commented on PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#issuecomment-3078933391
I opened https://github.com/apache/datafusion/issues/16800 to track the big
picture
--
This is an automated message from the Apache Git Service.
To respond to the message, please
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210616673
##
datafusion/datasource-parquet/src/row_filter.rs:
##
@@ -140,6 +143,8 @@ impl ArrowPredicate for DatafusionArrowPredicate {
}
fn evaluate(&mut self,
adriangb commented on PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#issuecomment-3078342870
> In particular I am not sure about the intended behavior when they are both
present
If you have an expression adapter you map the expression and the expression
is now evalua
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210213790
##
datafusion/datasource-parquet/src/row_filter.rs:
##
@@ -106,6 +106,8 @@ pub(crate) struct DatafusionArrowPredicate {
rows_matched: metrics::Count,
//
adriangb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210208739
##
docs/source/library-user-guide/upgrading.md:
##
@@ -120,6 +120,17 @@ SET datafusion.execution.spill_compression = 'zstd';
For more details about this config
alamb commented on code in PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#discussion_r2210136013
##
docs/source/library-user-guide/upgrading.md:
##
@@ -120,6 +120,17 @@ SET datafusion.execution.spill_compression = 'zstd';
For more details about this configura
adriangb commented on PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#issuecomment-3075481633
> I'd like to add a unit test that confirms the custom schema adapter
factory will be used if specified.
done
--
This is an automated message from the Apache Git Service.
T
adriangb commented on PR #16791:
URL: https://github.com/apache/datafusion/pull/16791#issuecomment-3074657503
I'd like to add a unit test that confirms the custom schema adapter factory
will be used if specified.
--
This is an automated message from the Apache Git Service.
To respond to t
15 matches
Mail list logo
