thinkharderdev merged PR #15544:
URL: https://github.com/apache/datafusion/pull/15544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
joroKr21 commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2065610845
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -288,10 +300,23 @@ impl Accumulator for ArrayAggAccumulator {
return internal_err!("expects
alamb commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2065191063
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -288,10 +300,23 @@ impl Accumulator for ArrayAggAccumulator {
return internal_err!("expects si
joroKr21 commented on PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#issuecomment-2833988848
This missed the v47 train. Anything else needed to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Dandandan commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2027495310
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -500,11 +548,30 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
return Ok(());
joroKr21 commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2026366689
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -500,11 +548,30 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
return Ok(());
gabotechs commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2026317591
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -3194,6 +3196,28 @@ select array_agg(column1) from t;
statement ok
drop table t;
+# array_agg_igno
gabotechs commented on code in PR #15544:
URL: https://github.com/apache/datafusion/pull/15544#discussion_r2026317591
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -3194,6 +3196,28 @@ select array_agg(column1) from t;
statement ok
drop table t;
+# array_agg_igno
joroKr21 opened a new pull request, #15544:
URL: https://github.com/apache/datafusion/pull/15544
## Which issue does this PR close?
- Closes #13742
- Part of #9924
## Rationale for this change
See the linked issues.
## What changes are included i
