alamb merged PR #14227:
URL: https://github.com/apache/datafusion/pull/14227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2650615478
I merged this PR locally and verified it compiles and passes tests, so
merging it in
Thanks again @cj-zhukov
--
This is an automated message from the Apache Git Service.
To r
alamb commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2641110054
> > @andygrove are we happy that dict_id is no longer needed in DataFusion?
>
> Yes, I think so. We have proven that we no longer need it in Comet, at
least. Thanks for the ping.
andygrove commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2640814818
> @andygrove are we happy that dict_id is no longer needed in DataFusion?
Yes, I think so. We have proven that we no longer need it in Comet, at
least. Thanks for the ping.
cj-zhukov commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2630563622
@alamb My apologies, I was trying to undo deletion of test in copy.slt with
07157a7 commit but accidentally added some PRs that should not be included here
--
This is an automate
alamb commented on code in PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#discussion_r1937639174
##
datafusion/proto-common/proto/datafusion_common.proto:
##
@@ -108,8 +108,7 @@ message Field {
// for complex data types like structs, unions
repeated Field
cj-zhukov commented on code in PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#discussion_r1937115713
##
datafusion/proto-common/proto/datafusion_common.proto:
##
@@ -108,8 +108,7 @@ message Field {
// for complex data types like structs, unions
repeated Fi
alamb commented on code in PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#discussion_r193740
##
datafusion/sqllogictest/test_files/copy.slt:
##
@@ -538,26 +538,6 @@ select * from validate_arrow_file;
1 Foo
2 Bar
-# Copy from dict encoded values to single
alamb commented on code in PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#discussion_r1937107757
##
datafusion/proto-common/proto/datafusion_common.proto:
##
@@ -108,8 +108,7 @@ message Field {
// for complex data types like structs, unions
repeated Field
cj-zhukov commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2627001851
> It seems that `datafusion/core/src/physical_optimizer/enforce_sorting.rs`
somehow is added to this PR accidentally (it was moved on main recently, so
perhaps this happened during
cj-zhukov commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2614365128
@alamb Andrew, I tried to fix the issues but I failed. Can you please help
me to understand how they can be fixed? When I run tests locally with cargo
test, I've got no issues.
cj-zhukov commented on PR #14227:
URL: https://github.com/apache/datafusion/pull/14227#issuecomment-2607139791
There are some conflicts that I'm afraid I don't know how to resolve. Any
help is welcomed.
--
This is an automated message from the Apache Git Service.
To respond to the messag
cj-zhukov opened a new pull request, #14227:
URL: https://github.com/apache/datafusion/pull/14227
## Which issue does this PR close?
Closes #14173.
## Rationale for this change
## What changes are included in this PR?
## Are these changes te
13 matches
Mail list logo
