findepi commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1946883460
##
datafusion/core/src/physical_planner.rs:
##
@@ -689,7 +693,7 @@ impl DefaultPhysicalPlanner {
if physical_field.data_type() !=
logical
findepi commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1946880617
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
comphead merged PR #14519:
URL: https://github.com/apache/datafusion/pull/14519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jayzhan211 commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1945670750
##
datafusion/core/src/physical_planner.rs:
##
@@ -689,7 +693,7 @@ impl DefaultPhysicalPlanner {
if physical_field.data_type() !=
logi
comphead commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1945427486
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
comphead commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1945425102
##
datafusion/core/src/physical_planner.rs:
##
@@ -689,7 +693,7 @@ impl DefaultPhysicalPlanner {
if physical_field.data_type() !=
logica
davisp commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1945136033
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
findepi commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1944353348
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
findepi commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1944355108
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
findepi commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1944351361
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
davisp commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1943793782
##
datafusion/core/src/schema_equivalence.rs:
##
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
findepi commented on PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#issuecomment-2638113219
cc @eejbyfeldt @tv42 @comphead @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
findepi opened a new pull request, #14519:
URL: https://github.com/apache/datafusion/pull/14519
Physical plan can be further optimized. In particular, an expression can be
determined as never null even if it wasn't known at the time of logical
planning. Thus, the final schema check needs to
13 matches
Mail list logo
