alamb merged PR #15709:
URL: https://github.com/apache/datafusion/pull/15709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#discussion_r2047360096
##
datafusion/sqllogictest/test_files/regexp/README.md:
##
@@ -0,0 +1,59 @@
+
+
+# Regexp Test Files
+
+This directory contains test files for regular expression (re
alamb commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2813053514
Thank you so much @kumarlokesh @comphead and @goldmedal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
comphead commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2809885498
Thanks, As long as test and its dependencies runs in the separate context we
are safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Omega359 commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2809757873
> > @comphead my understanding is that when a test file includes another
file using the `include` directive (like `include ./init_data.slt.part`), the
sqllogictest runner would proc
comphead commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2807835159
> @comphead my understanding is that when a test file includes another file
using the `include` directive (like `include ./init_data.slt.part`), the
sqllogictest runner would pr
alamb commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2807670836
> Seems like most recent pipeline failure is probably related to #15725.
Waiting for this to merge.
Merged!
--
This is an automated message from the Apache Git Service.
To res
kumarlokesh commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2807425699
Seems like most recent pipeline failure is probably related to
https://github.com/apache/datafusion/pull/15725. Waiting for this to merge.
--
This is an automated message from
kumarlokesh commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2807420910
> thanks @kumarlokesh I like it. However my understanding was sqllogictest
runner starts all files in parallel? do we have a guarantee data will be
initiated before tests run?
kumarlokesh commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2807387628
> Beyond the addition of null into the test data as mentioned by @goldmedal
I think this is a nice and clean refactor - thank you @kumarlokesh
@Omega359 @goldmedal addresse
Omega359 commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2805979758
Beyond the addition of null into the test data as mentioned by @goldmedal I
think this is a nice and clean refactor - thank you @kumarlokesh
--
This is an automated message from
Omega359 commented on code in PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#discussion_r2044849064
##
datafusion/sqllogictest/test_files/regexp/regexp_like.slt:
##
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contri
goldmedal commented on code in PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#discussion_r2044561531
##
datafusion/sqllogictest/test_files/regexp/init_data.slt.part:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more con
Omega359 commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2803304792
I'll take a look at this tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on PR #15709:
URL: https://github.com/apache/datafusion/pull/15709#issuecomment-2802863007
FYI @Omega359 and @goldmedal -- do you have some time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
kumarlokesh opened a new pull request, #15709:
URL: https://github.com/apache/datafusion/pull/15709
## Which issue does this PR close?
- Closes #14452.
## Rationale for this change
## What changes are included in this PR?
## Are these change
16 matches
Mail list logo
