alamb merged PR #16675:
URL: https://github.com/apache/datafusion/pull/16675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Standing-Man commented on code in PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#discussion_r2186251681
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2032,7 +2034,10 @@ impl SortMergeJoinStream {
let record_batch =
concat
comphead commented on code in PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#discussion_r2185865853
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2032,7 +2034,10 @@ impl SortMergeJoinStream {
let record_batch =
concat_bat
comphead commented on code in PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#discussion_r2185864775
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2032,7 +2034,10 @@ impl SortMergeJoinStream {
let record_batch =
concat_bat
Standing-Man commented on code in PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#discussion_r2184734711
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2032,7 +2034,10 @@ impl SortMergeJoinStream {
let record_batch =
concat
2010YOUY01 commented on code in PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#discussion_r2184636583
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2032,7 +2034,10 @@ impl SortMergeJoinStream {
let record_batch =
concat_b
jatin510 commented on PR #16675:
URL: https://github.com/apache/datafusion/pull/16675#issuecomment-3034553196
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Standing-Man opened a new pull request, #16675:
URL: https://github.com/apache/datafusion/pull/16675
## Which issue does this PR close?
- Closes #16493.
## Rationale for this change
Refactor SortMergeJoinMetrics to reuse BaselineMetrics
## What changes
