alamb commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2064516964
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -501,6 +501,21 @@ impl LogicalPlanBuilder {
if table_scan.filters.is_empty() {
if let Som
vadimpiven commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2827139938
Close in favour of https://github.com/apache/datafusion/pull/15825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vadimpiven closed pull request #15811: Preserve projection for inline scan
URL: https://github.com/apache/datafusion/pull/15811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jayzhan211 commented on PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#issuecomment-2827031377
Thanks @xudong963 @vadimpiven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jayzhan211 commented on code in PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#discussion_r2058012111
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +99,32 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<(
jayzhan211 commented on code in PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#discussion_r2058012111
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +99,32 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<(
jayzhan211 merged PR #15825:
URL: https://github.com/apache/datafusion/pull/15825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
vadimpiven commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2057920398
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +100,37 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<
vadimpiven commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2826910009
Updated the test code so we check that the projection is applied, not how it
is applied.
--
This is an automated message from the Apache Git Service.
To respond to the message,
vadimpiven commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2057920398
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +100,37 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<
jayzhan211 commented on PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#issuecomment-2825860245
You can merge this PR, I had kept the commit from @vadimpiven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jayzhan211 commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2057104794
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +100,37 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<
vadimpiven commented on code in PR #15825:
URL: https://github.com/apache/datafusion/pull/15825#discussion_r2056286726
##
datafusion/core/tests/execution/logical_plan.rs:
##
@@ -96,3 +100,37 @@ where
};
element
}
+
+#[test]
+fn inline_scan_projection_test() -> Result<
vadimpiven commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2824581546
You can merge your change and just close my PR, there is no difference to
the result for me.
--
This is an automated message from the Apache Git Service.
To respond to the messa
jayzhan211 commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2823998323
https://github.com/apache/datafusion/pull/15825
I couldn't open a PR to your repo. Here is the fix I did
--
This is an automated message from the Apache Git Service.
To re
jayzhan211 commented on code in PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#discussion_r2055814059
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -498,7 +498,7 @@ impl LogicalPlanBuilder {
TableScan::try_new(table_name, table_source, proje
vadimpiven commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2823765003
Thank you! Ok, will discuss making a fork and depending on it instead of
upstream with my team today.
--
This is an automated message from the Apache Git Service.
To respond to
xudong963 commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2823660336
> In the letter case I want to highlight that this change is blocking me
from updating to 47.0.0 version, and I would highly appreciate a patch release
with this fix.
If it'
xudong963 commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2823656330
> Should I wait for another review, or you can merge the change?
I'll wait for another to review, if not, I'll merge tomorrow.
> In the letter case I want to hi
vadimpiven commented on PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#issuecomment-2823619778
@xudong963 I do not have a merge button even after the review. Should I wait
for another review, or you can merge the change? In the letter case I want to
highlight that this chan
xudong963 commented on code in PR #15811:
URL: https://github.com/apache/datafusion/pull/15811#discussion_r2054259450
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -498,7 +498,7 @@ impl LogicalPlanBuilder {
TableScan::try_new(table_name, table_source, projec
vadimpiven opened a new pull request, #15811:
URL: https://github.com/apache/datafusion/pull/15811
## Which issue does this PR close?
- Closes #15810
## Rationale for this change
PR https://github.com/apache/datafusion/pull/15201 introduced a bug here
https://github.com/
22 matches
Mail list logo
