Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-11 Thread via GitHub
zhuqi-lucas commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2963037694 Thank you @alamb , i created a ticket for the support for csv tpch benchmark first. https://github.com/apache/datafusion/issues/16370 -- This is an automated message from th

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-10 Thread via GitHub
alamb commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2961158371 Marking as draft as I think this PR is no longer waiting on feedback and I am trying to make it easier to find PRs in need of review. Please mark it as ready for review when it is read

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-04 Thread via GitHub
alamb commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2939540830 > It looks like no performance improvement for h2o_window benchmark result... Now that I think about it, the h2o benchmark may not have any string columns 🤔 Do the TPCH b

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-04 Thread via GitHub
zhuqi-lucas commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2939581266 > > It looks like no performance improvement for h2o_window benchmark result... > > Now that I think about it, the h2o benchmark may not have any string columns 🤔 >

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-03 Thread via GitHub
zhuqi-lucas commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2938172961 It looks like no performance improvement for h2o_window benchmark result... -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-03 Thread via GitHub
alamb commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2936699578 🤖: Benchmark completed Details ``` Comparing HEAD and default_utf8_for_unkown_type Benchmark h2o_window.json

Re: [PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-03 Thread via GitHub
alamb commented on PR #16243: URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2936634009 🤖 `./gh_compare_branch.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh) Running Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun

[PR] Perf: load default Utf8View for CSV datatype [datafusion]

2025-06-03 Thread via GitHub
zhuqi-lucas opened a new pull request, #16243: URL: https://github.com/apache/datafusion/pull/16243 ## Which issue does this PR close? - Closes [#16241](https://github.com/apache/datafusion/issues/16241) ## Rationale for this change ## What changes are inc