Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-27 Thread via GitHub
kosiew commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2833965602 Closing this. Moving the configuration from Rust to Python in #1119 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-27 Thread via GitHub
kosiew closed pull request #1086: Partial fix for #1078 — [Add Dataframe display config] URL: https://github.com/apache/datafusion-python/pull/1086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-26 Thread via GitHub
timsaucer commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2832626596 Moving those over to your other work sounds like a great way to have one point of processing for all of these display options. I really love how all this work is coming toget

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-24 Thread via GitHub
kosiew commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2827426701 @timsaucer Should I move max_table_bytes min_table_rows: usize, max_table_rows_in_repr: usize, to the python DataFrameHtmlFormatter class as well?

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-05 Thread via GitHub
timsaucer commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2780731986 This looks great. I browsed it this morning, but it's a bit long so I will try to make some time tomorrow to get a more thorough review. -- This is an automated message fro

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-04-02 Thread via GitHub
kosiew commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2774638457 @timsaucer I moved the display config to session context. Can you review again? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-03-30 Thread via GitHub
kosiew commented on PR #1086: URL: https://github.com/apache/datafusion-python/pull/1086#issuecomment-2764985796 @timsaucer , Thanks for reviewing this. Do you mean to set display config at the context level instead? -- This is an automated message from the Apache Git Service.

[PR] Partial fix for #1078 — [Add Dataframe display config] [datafusion-python]

2025-03-28 Thread via GitHub
kosiew opened a new pull request, #1086: URL: https://github.com/apache/datafusion-python/pull/1086 ## Which issue does this PR close? Partial fix for #1078 ## Rationale for this change This PR adds configurable display settings for `DataFrame` representations in the Pyt