blaginin commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r2007638250
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
Review Comment:
Sorry -- before I added one more test, but then I have to remove it due to
(https://github.
goldmedal merged PR #15159:
URL: https://github.com/apache/datafusion/pull/15159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
goldmedal commented on PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#issuecomment-2747772795
Thanks @blaginin and @alamb for reviewing. I'll create a follow-up PR to
remove the duplicate test.
--
This is an automated message from the Apache Git Service.
To respond to the
goldmedal commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r2008701304
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -633,6 +633,18 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
parser_dialect: Box::new
alamb commented on PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#issuecomment-2737960183
Marking as draft as I think this PR is no longer waiting on feedback. Please
mark it as ready for review when it is ready for another look
--
This is an automated message from the A
alamb commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r1999670066
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
Review Comment:
I don't understand this comment -- doesn't this PR *add* a new test?
##
datafusion/s
blaginin commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r1998600989
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
Review Comment:
Had to remove this because now (even in main) it produces `SELECT * FROM
(SELECT [1, 2, 3]
blaginin commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r1998600989
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
Review Comment:
Had to remove this _new_ test because now (even in main) it produces `SELECT
* FROM (SELECT
blaginin commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r1997328648
##
datafusion/sql/src/unparser/plan.rs:
##
@@ -377,8 +377,17 @@ impl Unparser<'_> {
};
if self.dialect.unnest_as_table_factor()
goldmedal commented on code in PR #15159:
URL: https://github.com/apache/datafusion/pull/15159#discussion_r1991567742
##
datafusion/sql/src/unparser/plan.rs:
##
@@ -377,8 +377,17 @@ impl Unparser<'_> {
};
if self.dialect.unnest_as_table_factor()
blaginin opened a new pull request, #15159:
URL: https://github.com/apache/datafusion/pull/15159
## Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/15128
## Rationale for this change
We currently override source losing some data, see iss
11 matches
Mail list logo
