Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-11 Thread via GitHub
iffyio merged PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-09 Thread via GitHub
yoavcloud commented on PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#issuecomment-2579727087 @alamb @iffyio please see a more structured approach to the parsing of the session parameters -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-09 Thread via GitHub
yoavcloud commented on code in PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#discussion_r1908424296 ## src/parser/mod.rs: ## @@ -10307,11 +10307,67 @@ impl<'a> Parser<'a> { snapshot: None, session: false,

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-07 Thread via GitHub
alamb commented on code in PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#discussion_r1905447833 ## src/parser/mod.rs: ## @@ -10307,11 +10307,67 @@ impl<'a> Parser<'a> { snapshot: None, session: false, }

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-07 Thread via GitHub
alamb commented on PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#issuecomment-2575293097 fyi @iffyio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-07 Thread via GitHub
yoavcloud commented on PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#issuecomment-2575195680 @alamb done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-07 Thread via GitHub
alamb commented on PR #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646#issuecomment-2575103207 Hi @yoavcloud -- it looks like this PR has some conflicts -- is there any chance you can resolve them? -- This is an automated message from the Apache Git Service. To re

[PR] MsSQL SET for session params [datafusion-sqlparser-rs]

2025-01-06 Thread via GitHub
yoavcloud opened a new pull request, #1646: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1646 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To