xudong963 merged PR #14221:
URL: https://github.com/apache/datafusion/pull/14221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #14221:
URL: https://github.com/apache/datafusion/pull/14221#issuecomment-2608700121
Thanks @alamb @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
berkaysynnada commented on PR #14221:
URL: https://github.com/apache/datafusion/pull/14221#issuecomment-2608367142
> It's difficult for me to construct such ut, I didn't construct a test that
will go to the condition
>
>
https://github.com/apache/datafusion/blob/5edb27678d1b97e74bb83
alamb commented on code in PR #14221:
URL: https://github.com/apache/datafusion/pull/14221#discussion_r1926008342
##
datafusion/core/src/physical_optimizer/sort_pushdown.rs:
##
@@ -107,6 +107,12 @@ fn pushdown_sorts_helper(
// Make sure this `SortExec` satisfies par
xudong963 commented on PR #14221:
URL: https://github.com/apache/datafusion/pull/14221#issuecomment-2606619078
It's difficult for me to construct such ut, I didn't construct a test that
will go to the condition
https://github.com/apache/datafusion/blob/5edb27678d1b97e74bb83d185166980c901a9b
xudong963 commented on PR #14221:
URL: https://github.com/apache/datafusion/pull/14221#issuecomment-2606355222
> Thanks @xudong963. Can you also add a small unit test?
Thanks, I'll do it later
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
xudong963 opened a new pull request, #14221:
URL: https://github.com/apache/datafusion/pull/14221
## Which issue does this PR close?
Closes https://github.com/apache/datafusion/pull/14192#discussion_r1922215734
## Rationale for this change
## What changes
