alamb merged PR #13862:
URL: https://github.com/apache/datafusion/pull/13862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
robtandy commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894640008
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -368,14 +368,45 @@ pub fn to_substrait_rel(
.iter()
.map(|e| substra
robtandy commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894639389
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -368,14 +368,45 @@ pub fn to_substrait_rel(
.iter()
.map(|e| substra
robtandy commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894418929
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -368,14 +368,45 @@ pub fn to_substrait_rel(
.iter()
.map(|e| substra
robtandy commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894417992
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -200,6 +200,11 @@ async fn select_with_filter() -> Result<()> {
roundtrip("SELECT * FROM
Blizzara commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894416585
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -368,14 +368,45 @@ pub fn to_substrait_rel(
.iter()
.map(|e| substra
Blizzara commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894415637
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -368,14 +368,45 @@ pub fn to_substrait_rel(
.iter()
.map(|e| substra
robtandy commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894410849
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -200,6 +200,11 @@ async fn select_with_filter() -> Result<()> {
roundtrip("SELECT * FROM
alamb commented on code in PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#discussion_r1894409947
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -200,6 +200,11 @@ async fn select_with_filter() -> Result<()> {
roundtrip("SELECT * FROM da
robtandy commented on PR #13862:
URL: https://github.com/apache/datafusion/pull/13862#issuecomment-2557560399
Per contribution guide
```For new contributors a committer must first trigger the CI tasks. Please
mention the members from committers list in the PR to help trigger the CI```
robtandy opened a new pull request, #13862:
URL: https://github.com/apache/datafusion/pull/13862
## Which issue does this PR close?
Closes #13860
## Rationale for this change
Explained in #13860
## What changes are included in this PR?
## Are these chan
11 matches
Mail list logo