alamb merged PR #16369:
URL: https://github.com/apache/datafusion/pull/16369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#issuecomment-2969890728
Thanks @zhuqi-lucas and @simonvandel
cc @pepijnve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zhuqi-lucas commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2144101877
##
datafusion/physical-optimizer/Cargo.toml:
##
@@ -49,6 +49,7 @@ datafusion-physical-plan = { workspace = true }
itertools = { workspace = true }
log = { wo
simonvandel commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2143061438
##
datafusion/physical-optimizer/Cargo.toml:
##
@@ -49,6 +49,7 @@ datafusion-physical-plan = { workspace = true }
itertools = { workspace = true }
log = { wo
alamb commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2142595175
##
datafusion/physical-optimizer/src/insert_yield_exec.rs:
##
@@ -32,9 +34,10 @@ use datafusion_physical_plan::yield_stream::YieldStreamExec;
use datafusion_physica
zhuqi-lucas commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2142643694
##
datafusion/physical-optimizer/src/insert_yield_exec.rs:
##
@@ -92,3 +96,23 @@ impl PhysicalOptimizerRule for InsertYieldExec {
true
}
}
+
+#[
zhuqi-lucas commented on code in PR #16369:
URL: https://github.com/apache/datafusion/pull/16369#discussion_r2142611695
##
datafusion/physical-optimizer/src/insert_yield_exec.rs:
##
@@ -15,10 +15,12 @@
// specific language governing permissions and limitations
// under the Lic
zhuqi-lucas opened a new pull request, #16369:
URL: https://github.com/apache/datafusion/pull/16369
## Which issue does this PR close?
This is sub-task for:
https://github.com/apache/datafusion/issues/16353
## Rationale for this change
Add testing and p
