alamb merged PR #15255:
URL: https://github.com/apache/datafusion/pull/15255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2734485532
Thanks @shruti2522 and @blaginin 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on code in PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#discussion_r2001657619
##
datafusion/core/tests/user_defined/user_defined_table_functions.rs:
##
@@ -34,11 +34,19 @@ use datafusion::physical_plan::{collect, ExecutionPlan};
use datafusio
blaginin commented on code in PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#discussion_r2000968071
##
datafusion/core/tests/user_defined/user_defined_table_functions.rs:
##
@@ -34,11 +34,19 @@ use datafusion::physical_plan::{collect, ExecutionPlan};
use datafu
blaginin commented on code in PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#discussion_r2000967075
##
datafusion/core/tests/user_defined/user_defined_window_functions.rs:
##
@@ -57,30 +57,38 @@ const BOUNDED_WINDOW_QUERY: &str =
odd_counter(val) OVER (P
blaginin commented on code in PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#discussion_r2000955601
##
datafusion/core/tests/user_defined/expr_planner.rs:
##
@@ -73,52 +73,62 @@ async fn plan_and_collect(sql: &str) ->
Result> {
ctx.sql(sql).await?.collect(
shruti2522 commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2730590045
> > I tried allow_duplicates!(), but it gets a bit tricky with async
functions
>
> Can you please explain more on this? I tried modifying _async_
`run_and_compare_query` an
blaginin commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2729413005
> I tried allow_duplicates!(), but it gets a bit tricky with async functions
Can you please explain more on this? I tried modifying _async_
`run_and_compare_query` and this wo
shruti2522 commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2727447740
> Hey! I’m a bit worried that now to understand the test you’ll need to look
into two places: open the test file and also search for the snapshot file…
that’s why in the example p
blaginin commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2727325045
Hey! I’m a bit worried that now to understand the test you’ll need to look
into two places: open the test file and also search for the snapshot file…
that’s why in the example pr (h
alamb commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2727315704
cc @blaginin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #15255:
URL: https://github.com/apache/datafusion/pull/15255#issuecomment-2727315961
Thanks @shruti2522 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
shruti2522 opened a new pull request, #15255:
URL: https://github.com/apache/datafusion/pull/15255
## Which issue does this PR close?
- Closes #15247 .
## Rationale for this change
## What changes are included in this PR?
migrate tests in `datafusion/co
13 matches
Mail list logo
