blaginin commented on code in PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#discussion_r2017624415
##
datafusion/substrait/tests/cases/emit_kind_tests.rs:
##
@@ -109,18 +117,28 @@ mod tests {
let df = ctx.sql("SELECT a + 1, b + 2 FROM data").await?;
blaginin commented on PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#issuecomment-2759517667
> Closes https://github.com/apache/datafusion/issues/15398.
If you plan to do more prs, consider changing it to "related", so the ticket
won't get auto closed
--
This is an
blaginin commented on code in PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#discussion_r2017622164
##
datafusion/substrait/tests/cases/emit_kind_tests.rs:
##
@@ -109,18 +117,28 @@ mod tests {
let df = ctx.sql("SELECT a + 1, b + 2 FROM data").await?;
alamb commented on PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#issuecomment-2759206571
> And there are many more functions like this, I can't simply change them as
they accepts dynamically generated `plan_str` and `plan.schema()`. Changing
them into `assert_snapshot!` wi
qstommyshu commented on PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#issuecomment-2758556657
Hi @alamb and @blaginin ,
I this PR is mostly done. There are still some areas (non-trivial test cases
migration) where I'm not sure if I should or how should I migrate them
qstommyshu commented on PR #15444:
URL: https://github.com/apache/datafusion/pull/15444#issuecomment-2755817539
Just to clarify this PR is **NOT FINISHED YET**. I'm still awaiting for an
answer of the
[scope](https://github.com/apache/datafusion/issues/15398#issuecomment-2755795572)
of thi
