Re: [PR] Migrate dataframe tests to `insta` [datafusion]

2025-04-05 Thread via GitHub
blaginin commented on code in PR #15262: URL: https://github.com/apache/datafusion/pull/15262#discussion_r1998926847 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -75,34 +75,28 @@ async fn create_test_table() -> Result { } /// Executes an expression on the

Re: [PR] Migrate dataframe tests to `insta` [datafusion]

2025-03-17 Thread via GitHub
alamb merged PR #15262: URL: https://github.com/apache/datafusion/pull/15262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Migrate dataframe tests to `insta` [datafusion]

2025-03-17 Thread via GitHub
jsai28 commented on code in PR #15262: URL: https://github.com/apache/datafusion/pull/15262#discussion_r1998958709 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -75,34 +75,28 @@ async fn create_test_table() -> Result { } /// Executes an expression on the t

Re: [PR] Migrate dataframe tests to `insta` [datafusion]

2025-03-17 Thread via GitHub
blaginin commented on PR #15262: URL: https://github.com/apache/datafusion/pull/15262#issuecomment-2729279806 Thank you! FYI to fix fmt, you can `cargo fmt --all` and commit all files. I also find it useful to use this: https://github.com/apache/datafusion/blob/87eec43856a5d8cefef24

[PR] Migrate dataframe tests to `insta` [datafusion]

2025-03-16 Thread via GitHub
jsai28 opened a new pull request, #15262: URL: https://github.com/apache/datafusion/pull/15262 ## Which issue does this PR close? Closes #15245. ## Rationale for this change ## What changes are included in this PR? Migrated tests in `datafusion/core/tests/dataframe` to use