qstommyshu commented on PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#issuecomment-2899443238
> Thank you @qstommyshu for all the help getting this PR to a good state
You’re welcome! I'm happy to help!
--
This is an automated message from the Apache Git Service.
To
alamb commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2100968491
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4650,7 +4650,7 @@ fn test_prepare_statement_infer_types_from_join() {
assert_snapshot!(
plan,
alamb merged PR #16019:
URL: https://github.com/apache/datafusion/pull/16019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#issuecomment-2898938075
Thank you @qstommyshu for all the help getting this PR to a good state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
brayanjuls commented on PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#issuecomment-2896583479
@qstommyshu @alamb let me know if there are any additional changes you need
me to add to this PR, I think it should be ready.
--
This is an automated message from the Apache G
qstommyshu commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2085769121
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,17 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
alamb commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2085180878
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,15 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
alamb commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2085171533
##
datafusion/sqllogictest/test_files/prepare.slt:
##
@@ -92,7 +92,7 @@ DEALLOCATE my_plan
statement ok
PREPARE my_plan AS SELECT * FROM person WHERE id < $1;
-s
brayanjuls commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2083769931
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,17 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
qstommyshu commented on code in PR #16019:
URL: https://github.com/apache/datafusion/pull/16019#discussion_r2083691801
##
datafusion/sql/src/statement.rs:
##
@@ -710,6 +710,17 @@ impl SqlToRel<'_, S> {
*statement,
&mut planner_context,
brayanjuls opened a new pull request, #16019:
URL: https://github.com/apache/datafusion/pull/16019
## Which issue does this PR close?
Closes #16018
## Rationale for this change
As data types of prepare statement without explicit types declaration are
not included in the
11 matches
Mail list logo
