alamb merged PR #15905:
URL: https://github.com/apache/datafusion/pull/15905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2850999139
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
2010YOUY01 commented on code in PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#discussion_r2072352105
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -234,15 +235,45 @@ async fn run_test_file(
runner.with_column_validator(strict_column_validator);
gabotechs commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2846693410
Just so that people have a bit more context about why is this PR coming
suddenly out of the blue, I'm exploring [this
idea](https://github.com/apache/datafusion/issues/15069#issuec
berkaysynnada commented on code in PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#discussion_r2070694736
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -235,14 +235,38 @@ async fn run_test_file(
runner.with_normalizer(value_normalizer);
runner.
gabotechs commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2844394504
👍 Done! also added some failure indexes to help our eyes parse the different
errors quickly
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2843921122
> > I would prefer it to be limited to say the first 10. Otherwise this
looks good.
>
> 👍 no strong opinion here, I imagine that if more than 10 tests fail, it
means that someth
gabotechs commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2842631495
> I would prefer it to be limited to say the first 10. Otherwise this looks
good.
👍 no strong opinion here, I imagine that if more than 10 tests fail, it
means that somethin
Omega359 commented on PR #15905:
URL: https://github.com/apache/datafusion/pull/15905#issuecomment-2842522088
```
Runs all the sqllogictests in a single file even if some of them fail,
reporting all failures, instead of just the first one.
```
I would prefer it to be limited to say
gabotechs opened a new pull request, #15905:
URL: https://github.com/apache/datafusion/pull/15905
## Which issue does this PR close?
- Closes #.
## Rationale for this change
Improve the way errors get shown to the developer while running
sqllogictests.
10 matches
Mail list logo
