Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-09 Thread via GitHub
alamb commented on PR #14025: URL: https://github.com/apache/datafusion/pull/14025#issuecomment-2581304653 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-09 Thread via GitHub
alamb merged PR #14025: URL: https://github.com/apache/datafusion/pull/14025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-08 Thread via GitHub
alamb commented on PR #14025: URL: https://github.com/apache/datafusion/pull/14025#issuecomment-2578781820 Nice work @tlm365 @2010YOUY01 and @simonvandel ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
2010YOUY01 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1906203641 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: Offs

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
2010YOUY01 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1906203641 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: Offs

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
tlm365 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1905501646 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: OffsetSi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
tlm365 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1905501646 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: OffsetSi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
2010YOUY01 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1905442653 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: Offs

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-07 Thread via GitHub
tlm365 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1905054494 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: OffsetSi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-06 Thread via GitHub
tlm365 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1905010563 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: OffsetSi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-06 Thread via GitHub
tlm365 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1904999369 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: OffsetSi

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-06 Thread via GitHub
2010YOUY01 commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1904948133 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: Offs

Re: [PR] Improve perfomance of `reverse` function [datafusion]

2025-01-06 Thread via GitHub
simonvandel commented on code in PR #14025: URL: https://github.com/apache/datafusion/pull/14025#discussion_r1904839947 ## datafusion/functions/src/unicode/reverse.rs: ## @@ -116,14 +115,23 @@ pub fn reverse(args: &[ArrayRef]) -> Result { } } -fn reverse_impl<'a, T: Off

[PR] Improve perfomance of `reverse` function [datafusion]

2025-01-06 Thread via GitHub
tlm365 opened a new pull request, #14025: URL: https://github.com/apache/datafusion/pull/14025 ## Which issue does this PR close? Closes #. ## Rationale for this change Improve perfomance of `reverse` function. ## What changes are included in this PR?