alamb commented on code in PR #16670:
URL: https://github.com/apache/datafusion/pull/16670#discussion_r2183767743
##
datafusion/common/src/scalar/mod.rs:
##
@@ -895,17 +919,8 @@ fn dict_from_values(
}
macro_rules! typed_cast_tz {
-($array:expr, $index:expr, $ARRAYTYPE:id
alamb merged PR #16670:
URL: https://github.com/apache/datafusion/pull/16670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
findepi commented on PR #16670:
URL: https://github.com/apache/datafusion/pull/16670#issuecomment-3033380496
test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
findepi opened a new pull request, #16670:
URL: https://github.com/apache/datafusion/pull/16670
The `as_*_array` functions and the `downcast_value!` have the benefit of
reporting the array type when there is a mismatch. This makes the error message
more actionable.
- follows https://
