Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-10 Thread via GitHub
Chen-Yuan-Lai commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3060795405 > > I suspect updating the results was faster than it might have previously been thanks to the work @blaginin @Chen-Yuan-Lai have done to migrate most of our plan tests to `ins

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-09 Thread via GitHub
alamb merged PR #16645: URL: https://github.com/apache/datafusion/pull/16645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-09 Thread via GitHub
alamb commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3051989553 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-08 Thread via GitHub
alamb commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3050178802 > > I suspect updating the results was faster than it might have previously been thanks to the work @blaginin @Chen-Yuan-Lai have done to migrate most of our plan tests to `insta` >

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-08 Thread via GitHub
geetanshjuneja commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3049328530 > I suspect updating the results was faster than it might have previously been thanks to the work @blaginin @Chen-Yuan-Lai have done to migrate most of our plan tests to `inst

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-07 Thread via GitHub
alamb commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3046635728 > How to update tests in .slt files? Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest -- This is an automated message

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-07 Thread via GitHub
geetanshjuneja commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3046052285 How to update tests in .slt files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-07 Thread via GitHub
alamb commented on PR #16645: URL: https://github.com/apache/datafusion/pull/16645#issuecomment-3044952327 Seems a few tests need to be updated to get CI to pass. @geetanshjuneja can take a look? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-02 Thread via GitHub
alamb commented on code in PR #16645: URL: https://github.com/apache/datafusion/pull/16645#discussion_r2180842064 ## datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs: ## @@ -262,9 +262,9 @@ impl DisplayAs for BoundedWindowAggExec { .iter()

[PR] Improve display format of BoundedWindowAggExec [datafusion]

2025-07-01 Thread via GitHub
geetanshjuneja opened a new pull request, #16645: URL: https://github.com/apache/datafusion/pull/16645 ## Which issue does this PR close? Closes #15758 - Closes #. ## Rationale for this change We can see Debug format in this explain statement, turn it to Displa